Cannot 'Thank' Posts over 1 year old

marleyboy

I noticed it a few weeks ago. I didn't think it was some sort of hack, I just assumed that the team had hard wired the threads to 365 day max.

fermi

The whole post thank system is a custom hack.

This: https://www.vbulletin.org/forum/showthread.php?t=165673

Wired into that is the option not to allow thanks when a post is over X days old if you set the option, where the code tests against that option value, the post timestamp and the current time as...

function can_thank_this_post blah blah blah.......

{

####

if ($vbulletin->options['post_thanks_days_old'])
    {
        if (TIMENOW > (($vbulletin->options['post_thanks_days_old'] * 60 * 60 * 24) + $postinfo['dateline']))
        {
            return false;
        }
    }

So that function, assuming it's not been altered by the techies is getting post_thanks_days_old=365 from somewhere.

Former_MSE_Megan

Hi guys,

We've heard back from the Tech team and here's why the button doesn't work on posts over a year old:

A limit was put in place because users would be thanking old posts in the boards where 'Wow' is enabled and this would bring them up as a new post, when the deal was no longer available. This is obviously annoying for forumites so a long time ago we placed a limit on the Thanks function.

So it's actually a good thing! It stops old deals from popping up and you should still be able to keep the thanks, they will only decrease if someone unthanks the post or it gets deleted.

As for taking the function off those boards with Wow enabled, it's a lot of extra work for not much gain. We'll obviously take any feedback on board, so let us know if you think otherwise here

Thanks for flagging this up!

fermi

That makes sense, as I found it hard to believe it was not deliberate and coded in somehow, so can_thank_this_post always returned a false after 365 days no matter what the AdminCP option was set at.

redux

This afternoon I could not thank a post from the middle of this morning..

I got the warning I didn't have permission to access that page, and for a few moments assumed that the thread had just coincidentally been deleted, but no it was still there.

I could quote the same post as if about to reply, and I had thanked a slightly later post in the same thread only a few minutes earlier